Acoustic Guitar Body Maker --- Improved Version

This forum is for users to submit their own gadgets to the community
User avatar
Rcnewcomb
Vectric Archimage
Posts: 6351
Joined: Fri Nov 04, 2005 5:54 am
Model of CNC Machine: 24x36 GCnC/WinCNC with ATC
Location: San Jose, California, USA
Contact:

Re: Acoustic Guitar Body Maker --- Improved Version

Post by Rcnewcomb »

You could reduce letters to the following:
TL, TR
WL, WR
BL, BR
- Randall Newcomb
10 fingers in, 10 fingers out, another good day in the shop

User avatar
sharkcutup
Vectric Wizard
Posts: 3437
Joined: Sat Mar 26, 2016 3:48 pm
Model of CNC Machine: Shark HD3 Pro Extended Bed with Spindle
Location: U.S.A.

Re: Acoustic Guitar Body Maker --- Improved Version

Post by sharkcutup »

Rcnewcomb wrote:
Fri Oct 25, 2024 4:08 pm
You could reduce letters to the following:
TL, TR
WL, WR
BL, BR
Yup, That is definitely is doable!

Thank You!

Sharkcutup
V-Carve Pro Tips, Gadget Tips & Videos
YouTube Channel - Sharkcutup CNC
V-Carve Pro 12.013

User avatar
sharkcutup
Vectric Wizard
Posts: 3437
Joined: Sat Mar 26, 2016 3:48 pm
Model of CNC Machine: Shark HD3 Pro Extended Bed with Spindle
Location: U.S.A.

Re: Acoustic Guitar Body Maker --- Improved Version

Post by sharkcutup »

Hello Everyone,

Here is the Long Awaited Guitar Body Maker Gadget ---

Sorry for the Delay had several quirks to work out in the code.

Comments and Suggestions are always Welcomed!

Item Changed/Added:

1. Added the Caul Blocks for the Caul Spreaders! The Caul Blocks average 2.5" to the Guitar Body Length.
2. Fixed the Job Setup Entry Dialog Messaging related to the XY Datum Location.
3. Added Toolpathing for all Vectors.


https://www.dropbox.com/scl/fi/8476yfd1 ... wi4cu&dl=0
Rename to Guitar Body Maker_Ver_4.0.vgadget
File Was TOO LARGE even zipped to attach here!

Current Version: 4.0
Supports: 12.0 versions of V-Carve Pro, and Aspire --- Not sure about any of the other previous Vectric Versions

Installation Instructions:

1. Download the gadget Guitar Body Maker_Ver_4.0-MINE.zip from My Dropbox.
2. Rename it from GuitarBody Maker_Ver_4.0-MNE.zip to Guitar Body Maker_Ver_4.0.vgadget
3. In Vectric Pro or Aspire click on Gadgets -> Install New Gadget and navigate to where you downloaded the above noted file to select it and click Ok.

It should give you a pop up saying the gadget was installed and you should see Guitar Body Maker_Ver_4.0 in the Gadgets Menu. After Installing Close Software Program then Restart Software Program for using Gadget.

*** Note: There is One Quirk I am along with Vectric Supoport still trying to find a fix for. That is The Included Angle(A) of the V-Bit. No matter what V-Bit you select with the gadget from your Tool Database the Vectric Software insists on 90 Degrees using the gadget selection.
So it is IMPERATIVE that you go to the V-Bit Toolpath > Edit Tool, change the Included Angle(A) to whatever angled bit you have chosen from your Tool Database and Recalculate the Toolpath.

Next up ---
Continue to monitor gadget and possibly add more Guitar Body Styles, etc...

If you find an issue with any portion of the gadget, please let me know. I will do what I can to fix it within hours not days and/or weeks.

Cheers!
Sharkcutup
V-Carve Pro Tips, Gadget Tips & Videos
YouTube Channel - Sharkcutup CNC
V-Carve Pro 12.013

User avatar
adze_cnc
Vectric Wizard
Posts: 5109
Joined: Sat Jul 27, 2013 10:08 pm
Model of CNC Machine: AXYZ 4008 (VCarve Pro v9.519)
Location: Vancouver, BC, Canada

Re: Acoustic Guitar Body Maker --- Improved Version

Post by adze_cnc »

sharkcutup wrote:
Fri Nov 15, 2024 10:22 pm
*** Note: There is One Quirk I am along with Vectric Supoport still trying to find a fix for. That is The Included Angle(A) of the V-Bit. No matter what V-Bit you select with the gadget from your Tool Database the Vectric Software insists on 90 Degrees using the gadget selection.

So it is IMPERATIVE that you go to the V-Bit Toolpath > Edit Tool, change the Included Angle(A) to whatever angled bit you have chosen from your Tool Database and Recalculate the Toolpath.
The v-bit always giving 90 degrees problem is trivial to solve. The code samples and the definitions in the gadget SDK PDF are wrong. They have been wrong since day one.

In the PDF they suggest using something like:

Code: Select all

tool.VBitAngle = 60
This should be:

Code: Select all

tool.VBit_Angle = 60
For you you need to change the following:

File "Guitar Body Maker Milling_Ver4.0.xlua" lines 179 and 364 and file "Guitar Body Maker Registry_Ver4.0.xlua" line 219.

Check my Stipple gadget for a sample.

----------------

Some other things you might look at:

File: "Guitar Body Maker Dialog_Ver_4.0.xlua"

line 957: the PresentMessage function definition in "Guitar Body Maker Tools_Ver_4.0.xlua" expects only 3 parameters instead of the 4 in this line.

File: "Guitar Body Maker REgistry_Ver_4.0.xlua"

lines 191 & 196: the StartDate function is being passed "false" but the definition in file: "Guitar Body Maker Tools_Ver_4.0.xlua" expects no parameters.

File: "Guitar Body Maker_Ver_4.0.lua"

lines 235, 239, 243, and 247: the function CreateLayerProfiledToolpath is passing 8 parameters but the definition in file: "Gutar Body Maker)Ver_4.0.xlua" expects only 6 parameters.

Continuing with lines 234 to 248 you could replace them with (after fixing errors):

Code: Select all

if Toolpathing  then
  CreateLayerProfiledToolpath(Guitar.job, Guitar.ProfileLayerName_1, Milling.BodyStyleName, 0.0, Milling.Profile_ON_Cut_Depth, "ON", Milling.Thickness, DXF.Unit)
  CreateLayerProfiledToolpath(Guitar.job, Guitar.ProfileLayerName_2, Milling.BodyStyleName, 0.0, Milling.Profile_Cut_Depth, "IN" , Milling.Thickness, DXF.Unit)
  CreateLayerProfiledToolpath(Guitar.job, Guitar.ProfileLayerName_3, Milling.BodyStyleName, 0.0, Milling.Profile_Cut_Depth, "OUT" , Milling.Thickness, DXF.Unit)
  CreateLayerProfiledToolpath(Guitar.job, Guitar.ProfileLayerName_4, Milling.BodyStyleName, 0.0, Milling.Profile_Cut_Depth, "IN" , Milling.Thickness, DXF.Unit)
end

User avatar
sharkcutup
Vectric Wizard
Posts: 3437
Joined: Sat Mar 26, 2016 3:48 pm
Model of CNC Machine: Shark HD3 Pro Extended Bed with Spindle
Location: U.S.A.

Re: Acoustic Guitar Body Maker --- Improved Version

Post by sharkcutup »

adze_cnc wrote:
Fri Nov 15, 2024 11:55 pm
sharkcutup wrote:
Fri Nov 15, 2024 10:22 pm
*** Note: There is One Quirk I am along with Vectric Supoport still trying to find a fix for. That is The Included Angle(A) of the V-Bit. No matter what V-Bit you select with the gadget from your Tool Database the Vectric Software insists on 90 Degrees using the gadget selection.

So it is IMPERATIVE that you go to the V-Bit Toolpath > Edit Tool, change the Included Angle(A) to whatever angled bit you have chosen from your Tool Database and Recalculate the Toolpath.
The v-bit always giving 90 degrees problem is trivial to solve. The code samples and the definitions in the gadget SDK PDF are wrong. They have been wrong since day one.

In the PDF they suggest using something like:

Code: Select all

tool.VBitAngle = 60
This should be:

Code: Select all

tool.VBit_Angle = 60
For you you need to change the following:

File "Guitar Body Maker Milling_Ver4.0.xlua" lines 179 and 364 and file "Guitar Body Maker Registry_Ver4.0.xlua" line 219.

Check my Stipple gadget for a sample.

----------------

Some other things you might look at:

File: "Guitar Body Maker Dialog_Ver_4.0.xlua"

line 957: the PresentMessage function definition in "Guitar Body Maker Tools_Ver_4.0.xlua" expects only 3 parameters instead of the 4 in this line.

File: "Guitar Body Maker REgistry_Ver_4.0.xlua"

lines 191 & 196: the StartDate function is being passed "false" but the definition in file: "Guitar Body Maker Tools_Ver_4.0.xlua" expects no parameters.

File: "Guitar Body Maker_Ver_4.0.lua"

lines 235, 239, 243, and 247: the function CreateLayerProfiledToolpath is passing 8 parameters but the definition in file: "Gutar Body Maker)Ver_4.0.xlua" expects only 6 parameters.

Continuing with lines 234 to 248 you could replace them with (after fixing errors):

Code: Select all

if Toolpathing  then
  CreateLayerProfiledToolpath(Guitar.job, Guitar.ProfileLayerName_1, Milling.BodyStyleName, 0.0, Milling.Profile_ON_Cut_Depth, "ON", Milling.Thickness, DXF.Unit)
  CreateLayerProfiledToolpath(Guitar.job, Guitar.ProfileLayerName_2, Milling.BodyStyleName, 0.0, Milling.Profile_Cut_Depth, "IN" , Milling.Thickness, DXF.Unit)
  CreateLayerProfiledToolpath(Guitar.job, Guitar.ProfileLayerName_3, Milling.BodyStyleName, 0.0, Milling.Profile_Cut_Depth, "OUT" , Milling.Thickness, DXF.Unit)
  CreateLayerProfiledToolpath(Guitar.job, Guitar.ProfileLayerName_4, Milling.BodyStyleName, 0.0, Milling.Profile_Cut_Depth, "IN" , Milling.Thickness, DXF.Unit)
end
Wow! Okayyyyyyy, Thank You Stephen!

I will go back to the drawing board "as they say" --- fix and/or correct what you have noted --- Again a Very Sincere Thank You!

You are correct on that VBit_Angle it worked!!! Thank You! Now to look at the rest of your noted items.

Sharkcutup
V-Carve Pro Tips, Gadget Tips & Videos
YouTube Channel - Sharkcutup CNC
V-Carve Pro 12.013

User avatar
sharkcutup
Vectric Wizard
Posts: 3437
Joined: Sat Mar 26, 2016 3:48 pm
Model of CNC Machine: Shark HD3 Pro Extended Bed with Spindle
Location: U.S.A.

Re: Acoustic Guitar Body Maker --- Improved Version

Post by sharkcutup »

Hello Everyone,

Here is the Long Awaited Guitar Body Maker Gadget again ---

Sorry for the Delay had several quirks to work out in the code.

Comments and Suggestions are always Welcomed! Thank You ADZE_CNC!

Item Changed/Added:

1. Fixed the Persistent 90 Degree Issue in the Included Angle(A) Input Box.
2. Also Fixed a few other noted issues.

https://www.dropbox.com/scl/fi/0c1xvpmg ... vc3a8&dl=0
Rename to Guitar Body Maker_Ver_4.1.vgadget
File Was TOO LARGE even zipped to attach here!

Current Version: 4.1
Supports: 12.0 versions of V-Carve Pro, and Aspire --- Not sure about any of the other previous Vectric Versions

Installation Instructions:

1. Download the gadget Guitar Body Maker_Ver_4.1.zip from My Dropbox.
2. Rename it from GuitarBody Maker_Ver_4.1.zip to Guitar Body Maker_Ver_4.1.vgadget
3. In Vectric Pro or Aspire click on Gadgets -> Install New Gadget and navigate to where you downloaded the above noted file to select it and click Ok.

It should give you a pop up saying the gadget was installed and you should see Guitar Body Maker_Ver_4.1 in the Gadgets Menu. After Installing Close Software Program then Restart Software Program for using Gadget.

Next up ---
Continue to monitor gadget and possibly add more Guitar Body Styles, etc...

If you find an issue with any portion of the gadget, please let me know. I will do what I can to fix it within hours not days and/or weeks.

Cheers!
Sharkcutup
V-Carve Pro Tips, Gadget Tips & Videos
YouTube Channel - Sharkcutup CNC
V-Carve Pro 12.013

User avatar
Rcnewcomb
Vectric Archimage
Posts: 6351
Joined: Fri Nov 04, 2005 5:54 am
Model of CNC Machine: 24x36 GCnC/WinCNC with ATC
Location: San Jose, California, USA
Contact:

Re: Acoustic Guitar Body Maker --- Improved Version

Post by Rcnewcomb »

No bueno
Attachments
Screenshot 2024-11-15 180912.png
- Randall Newcomb
10 fingers in, 10 fingers out, another good day in the shop

User avatar
sharkcutup
Vectric Wizard
Posts: 3437
Joined: Sat Mar 26, 2016 3:48 pm
Model of CNC Machine: Shark HD3 Pro Extended Bed with Spindle
Location: U.S.A.

Re: Acoustic Guitar Body Maker --- Improved Version

Post by sharkcutup »

Rcnewcomb wrote:
Sat Nov 16, 2024 3:10 am
No bueno
https://www.dropbox.com/scl/fi/r43dwhyy ... cgcpi&dl=0

Try This One !!!

So many things to remember ---- arrrrgh!!!

Sharkcutup
V-Carve Pro Tips, Gadget Tips & Videos
YouTube Channel - Sharkcutup CNC
V-Carve Pro 12.013

User avatar
sharkcutup
Vectric Wizard
Posts: 3437
Joined: Sat Mar 26, 2016 3:48 pm
Model of CNC Machine: Shark HD3 Pro Extended Bed with Spindle
Location: U.S.A.

Re: Acoustic Guitar Body Maker --- Improved Version

Post by sharkcutup »

It has been Noted that the Gibson J200 Style was not functioning in the Gadget. While there tended to a few other minor issues.

So Here is the Guitar Body Maker Version 4.2 Correcting that Issue ----

https://www.dropbox.com/scl/fi/qmcd8pqd ... 557fk&dl=0

Be sure to rename the file before installing into Aspire or V-Carve Pro to --- Guitar Body Maker_Ver_4.2.vgadget

Comments and Suggestions Always Welcomed!

Sharkcutup
V-Carve Pro Tips, Gadget Tips & Videos
YouTube Channel - Sharkcutup CNC
V-Carve Pro 12.013

User avatar
Rcnewcomb
Vectric Archimage
Posts: 6351
Joined: Fri Nov 04, 2005 5:54 am
Model of CNC Machine: 24x36 GCnC/WinCNC with ATC
Location: San Jose, California, USA
Contact:

Re: Acoustic Guitar Body Maker --- Improved Version

Post by Rcnewcomb »

Used the Martin Dreadnaught, with a 1/4" 60° V bit, and a 1/4" end mill. Received this error.
Screenshot 2024-11-17 201006.png
I'd recommend using "t" rather than hard-coding the cutout at 1.5"
- Randall Newcomb
10 fingers in, 10 fingers out, another good day in the shop

User avatar
sharkcutup
Vectric Wizard
Posts: 3437
Joined: Sat Mar 26, 2016 3:48 pm
Model of CNC Machine: Shark HD3 Pro Extended Bed with Spindle
Location: U.S.A.

Re: Acoustic Guitar Body Maker --- Improved Version

Post by sharkcutup »

Thank You, Randall

I will look into this.

Sharkcutup
V-Carve Pro Tips, Gadget Tips & Videos
YouTube Channel - Sharkcutup CNC
V-Carve Pro 12.013

User avatar
adze_cnc
Vectric Wizard
Posts: 5109
Joined: Sat Jul 27, 2013 10:08 pm
Model of CNC Machine: AXYZ 4008 (VCarve Pro v9.519)
Location: Vancouver, BC, Canada

Re: Acoustic Guitar Body Maker --- Improved Version

Post by adze_cnc »

Guitar Body Maker Registry,,,,.xlua:

Code: Select all

function ExportWriter(xFile, Pdialog) -- Export All Settings
  local X = ""
  if Pdialog then 
    x = Project.ProjectPath .. "\\"  .. xFile .. "-" .. StartDate(false) .. ".Export"
  else
    x = xFile
  end
X capitalization problem. Either change the "local X" to lowercase or the "x = " to uppercase.

User avatar
sharkcutup
Vectric Wizard
Posts: 3437
Joined: Sat Mar 26, 2016 3:48 pm
Model of CNC Machine: Shark HD3 Pro Extended Bed with Spindle
Location: U.S.A.

Re: Acoustic Guitar Body Maker --- Improved Version

Post by sharkcutup »

adze_cnc wrote:
Mon Nov 18, 2024 6:36 pm
Guitar Body Maker Registry,,,,.xlua:

Code: Select all

function ExportWriter(xFile, Pdialog) -- Export All Settings
  local X = ""
  if Pdialog then 
    x = Project.ProjectPath .. "\\"  .. xFile .. "-" .. StartDate(false) .. ".Export"
  else
    x = xFile
  end
X capitalization problem. Either change the "local X" to lowercase or the "x = " to uppercase.
Yup, Thank You, ADZE_CNC!

It seems the Export File is causing the Issue Randall is seeing and some that I have been seeing also with more testing.
I may be looking into a User Option Checkbox for the Export File. Checked would create the Export File once the Necessary Path Information is input by the User. Unchecked the Export file would NOT be created.

I am also going to create a video showing the usage of the gadget and some of the minor quirks I have yet to work on which is mostly related to the Export File. As far as the Vectors, Layers and Toolpaths all is well there as far as I can tell.

Thank you for your Support and Interest,
Sharkcutup
V-Carve Pro Tips, Gadget Tips & Videos
YouTube Channel - Sharkcutup CNC
V-Carve Pro 12.013

User avatar
sharkcutup
Vectric Wizard
Posts: 3437
Joined: Sat Mar 26, 2016 3:48 pm
Model of CNC Machine: Shark HD3 Pro Extended Bed with Spindle
Location: U.S.A.

Re: Acoustic Guitar Body Maker --- Improved Version

Post by sharkcutup »

Hello Everyone,

I have solved the issues with the Export File hiccups. When Toolpathing the User will still be required to create a path on their computer for this file. For a possible future Version I am looking into the idea of a checkbox (Yes/No) for the Export File but in the meantime it is recommended to make use of it. Of course though the User can select to create only the Vectors on Layers and then create their own Toolpaths thereby, bypassing the need for the Export File.

Also this is just a recommendation --- The User of the Gadget may want to get in the habit of using the Gadget Reset before using gadget due user may not remember when or where (Imperial or Metric) gadget was used last.

Comments and Suggestions are always Welcomed!

Item Changed/Added:
1.) Fixed Issues related to the Export File
2.) Also Fixed a few other noted issues.

File Was TOO LARGE even zipped to attach here!

https://www.dropbox.com/scl/fi/aoy2sne4 ... qh6fi&dl=0

Rename to Guitar Body Maker_Ver_4.3.vgadget

Current Version: 4.3
Supports: 12.0 versions of V-Carve Pro, and Aspire --- Not sure about any of the other previous Vectric Versions

Installation Instructions:
1. Download the gadget Guitar Body Maker_Ver_4.3.zip from My Dropbox.
2. Rename it from GuitarBody Maker_Ver_4.3.zip to Guitar Body Maker_Ver_4.3.vgadget
3. In Vectric Pro or Aspire click on Gadgets -> Install New Gadget and navigate to where you downloaded the above noted file to select it and click Ok.

It should give you a pop up saying the gadget was installed and you should see Guitar Body Maker_Ver_4.3 in the Gadgets Menu. After Installing Close Software Program then Restart Software Program for using Gadget.

Next up ---
Continue to monitor gadget and possibly add more Guitar Body Styles, etc...

If you find an issue with any portion of the gadget, please let me know. I will do what I can to fix it within hours not days and/or weeks.

Here is a link to a video which shows how the gadget functions


Cheers!
Sharkcutup
V-Carve Pro Tips, Gadget Tips & Videos
YouTube Channel - Sharkcutup CNC
V-Carve Pro 12.013

User avatar
adze_cnc
Vectric Wizard
Posts: 5109
Joined: Sat Jul 27, 2013 10:08 pm
Model of CNC Machine: AXYZ 4008 (VCarve Pro v9.519)
Location: Vancouver, BC, Canada

Re: Acoustic Guitar Body Maker --- Improved Version

Post by adze_cnc »

One thing to watch out for is the function ifT(x)

It will behave oddly if presented a non-Boolean value:

Code: Select all

print(ifT("abc")) -- returns: Yes
print(ifT(123.56)) -- returns: Yes
print(ifT(nil)) -- returns: No
You could add...

Code: Select all

assert(type(x) == "boolean", "Argument must be a true or false value.")
...to catch passing non-Boolean values during testing.

You could also use:

Code: Select all

function ifT(x)
  assert(type(x) == "boolean", "Argument must be a true or false value.")
  return x and "yes" or "no"
end
To tighten things up a bit.

Post Reply